Skip to content

profiling: fix profiling chonk view #91873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 18, 2025
Merged

profiling: fix profiling chonk view #91873

merged 8 commits into from
Jun 18, 2025

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented May 19, 2025

Core buttons are not compatible with chonk, so we won't try to use them.

Use transparent variant buttons available in new UI

Fixes DE-62, DE-61, DE-59

CleanShot 2025-05-19 at 12 41 48@2x

@JonasBa JonasBa requested a review from a team as a code owner May 19, 2025 16:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 19, 2025
@JonasBa JonasBa requested a review from a team May 20, 2025 13:14
@JonasBa
Copy link
Member Author

JonasBa commented May 21, 2025

@TkDodo This is ready for another look. I've went ahead and used the transparent button. I will port the transparent variant to the new theme and remove the ts-expect-error decl next

Copy link
Contributor

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d say let’s merge #92025 first, then remove the ts-expect-error from here 👍

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #91873       +/-   ##
===========================================
+ Coverage   45.29%   87.63%   +42.34%     
===========================================
  Files       10314    10353       +39     
  Lines      595632   585680     -9952     
  Branches    23162    22565      -597     
===========================================
+ Hits       269771   513253   +243482     
+ Misses     325402    71999   -253403     
+ Partials      459      428       -31     

@getsantry
Copy link
Contributor

getsantry bot commented Jun 18, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jun 18, 2025
@TkDodo
Copy link
Contributor

TkDodo commented Jun 18, 2025

@JonasBa are we gonna ship this?

@JonasBa JonasBa removed the Stale label Jun 18, 2025
@JonasBa JonasBa merged commit e7cc445 into master Jun 18, 2025
46 checks passed
@JonasBa JonasBa deleted the jb/profiling/chonk-tabs branch June 18, 2025 17:52
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
~Core buttons are not compatible with chonk, so we won't try to use
them.~

Use transparent variant buttons available in new UI

Fixes DE-62, DE-61, DE-59

![CleanShot 2025-05-19 at 12 41
48@2x](https://github.com/user-attachments/assets/05ecf11a-068e-4eab-80df-6110eae7401d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants