-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
profiling: fix profiling chonk view #91873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
static/app/components/profiling/flamegraph/flamegraphDrawer/differentialFlamegraphDrawer.tsx
Show resolved
Hide resolved
@TkDodo This is ready for another look. I've went ahead and used the transparent button. I will port the transparent variant to the new theme and remove the ts-expect-error decl next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d say let’s merge #92025 first, then remove the ts-expect-error from here 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91873 +/- ##
===========================================
+ Coverage 45.29% 87.63% +42.34%
===========================================
Files 10314 10353 +39
Lines 595632 585680 -9952
Branches 23162 22565 -597
===========================================
+ Hits 269771 513253 +243482
+ Misses 325402 71999 -253403
+ Partials 459 428 -31 |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@JonasBa are we gonna ship this? |
~Core buttons are not compatible with chonk, so we won't try to use them.~ Use transparent variant buttons available in new UI Fixes DE-62, DE-61, DE-59 
Core buttons are not compatible with chonk, so we won't try to use them.Use transparent variant buttons available in new UI
Fixes DE-62, DE-61, DE-59