-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
🔧 chore(integrations): remove disabled integration logic #92210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92210 +/- ##
==========================================
+ Coverage 88.02% 88.03% +0.01%
==========================================
Files 10340 10335 -5
Lines 597284 596757 -527
Branches 23193 23193
==========================================
- Hits 525751 525351 -400
+ Misses 71072 70945 -127
Partials 461 461 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, but deferring to @sentaur-athena to give the final thumbs up for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤠
a5f2b12
to
f721ade
Compare
this logic has been broken and disabled for year+ now. deleting the code for it. if we rebuild it, we can checkout this commit in the future Contributes to ECO-542
this logic has been broken and disabled for year+ now. deleting the code for it. if we rebuild it, we can checkout this commit in the future
Contributes to ECO-542