Skip to content

🔧 chore(integrations): remove disabled integration logic #92210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

iamrajjoshi
Copy link
Member

@iamrajjoshi iamrajjoshi commented May 23, 2025

this logic has been broken and disabled for year+ now. deleting the code for it. if we rebuild it, we can checkout this commit in the future

Contributes to ECO-542

@iamrajjoshi iamrajjoshi self-assigned this May 23, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92210      +/-   ##
==========================================
+ Coverage   88.02%   88.03%   +0.01%     
==========================================
  Files       10340    10335       -5     
  Lines      597284   596757     -527     
  Branches    23193    23193              
==========================================
- Hits       525751   525351     -400     
+ Misses      71072    70945     -127     
  Partials      461      461              

@iamrajjoshi iamrajjoshi marked this pull request as ready for review May 27, 2025 16:51
@iamrajjoshi iamrajjoshi requested review from a team as code owners May 27, 2025 16:51
Copy link
Member

@GabeVillalobos GabeVillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but deferring to @sentaur-athena to give the final thumbs up for this.

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@iamrajjoshi iamrajjoshi merged commit 0a55cd2 into master Jun 18, 2025
63 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/remove-disable-integration-logic branch June 18, 2025 19:32
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
this logic has been broken and disabled for year+ now. deleting the code
for it. if we rebuild it, we can checkout this commit in the future

Contributes to ECO-542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants