feat(replays): Add bulk delete endpoint blueprint #92315
Merged
+110
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92315 +/- ##
==========================================
- Coverage 88.02% 88.02% -0.01%
==========================================
Files 10324 10326 +2
Lines 594990 595629 +639
Branches 23127 23127
==========================================
+ Hits 523766 524282 +516
- Misses 70731 70854 +123
Partials 493 493 |
aliu39
approved these changes
May 27, 2025
src/sentry/replays/blueprints/api.md
Outdated
| | dateUpdated | string | - | | ||
| | rangeStart | string | The minimum UTC timestamp in the deletion range. | | ||
| | rangeEnd | string | The maximum UTC timestamp in the deletion range. | | ||
| | environment | optional[string] | The environment to delete replays from. | |
|
|
||
| Delete a collection of replays. Deletes are throttled and will take some time to complete. The number of events expected to be deleted is returned on the meta object. This number is ephemeral and can change. It is only returned for informational reasons. | ||
|
|
||
| - Request |
There was a problem hiding this comment.
Can we add a request params table here too
| } | ||
| ``` | ||
|
|
||
| - Response 201 |
There was a problem hiding this comment.
Suggested change
| - Response 201 | |
| - Response 201 | |
| Response attributes are the same as GET. |
|
|
||
| ### Get Replay Delete Job [GET] | ||
|
|
||
| Fetch a replay delete job instance. |
src/sentry/replays/blueprints/api.md
Outdated
|
|
||
| ### Schedule Replay Collection Deletion [PUT] | ||
|
|
||
| An empty PUT request is made to the endpoint. The instance is scheduled for processing if it was in a pending state. |
billyvg
reviewed
May 28, 2025
src/sentry/replays/blueprints/api.md
Outdated
| } | ||
| ``` | ||
|
|
||
| ### Schedule Replay Collection Deletion [PUT] |
There was a problem hiding this comment.
What's the difference between this and creating a deletion?
Co-authored-by: Billy Vong <[email protected]>
Co-authored-by: Billy Vong <[email protected]>
Co-authored-by: Andrew Liu <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Andrew Liu <[email protected]>
Co-authored-by: Andrew Liu <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Billy Vong <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
billyvg
added a commit
that referenced
this pull request
Jun 18, 2025
Adds blueprint for proposed bulk delete endpoint. --------- Co-authored-by: Billy Vong <[email protected]> Co-authored-by: Andrew Liu <[email protected]> Co-authored-by: Bruno Garcia <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Adds blueprint for proposed bulk delete endpoint. --------- Co-authored-by: Billy Vong <[email protected]> Co-authored-by: Andrew Liu <[email protected]> Co-authored-by: Bruno Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds blueprint for proposed bulk delete endpoint.