Skip to content

releases: fix button overflow #92344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

releases: fix button overflow #92344

merged 1 commit into from
Jun 18, 2025

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented May 27, 2025

This column only ever contains a single button with View text, meaning we can remove the overflow: hidden rule entirely.

<ViewColumn>
    <GuideAnchor disabled={!isTopRelease || index !== 0} target="view_release">
      <LinkButton ...>
        {t('View')}
      </LinkButton>
    </GuideAnchor>
  </ViewColumn>

CleanShot 2025-05-27 at 15 23 14@2x

@JonasBa JonasBa requested a review from a team as a code owner May 27, 2025 19:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 27, 2025
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this impact GuideAnchor at all?

@JonasBa
Copy link
Member Author

JonasBa commented May 27, 2025

@billyvg I don't think it should. From what I can tell that component will just wrap and render the children that are passed down to it, and in this case, the children can only be the LinkButton.

The actual tour seem to be rendered in a portal to document.body, so that should escape the overflow rules already

@getsantry
Copy link
Contributor

getsantry bot commented Jun 18, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jun 18, 2025
@JonasBa JonasBa merged commit 8415f06 into master Jun 18, 2025
45 checks passed
@JonasBa JonasBa deleted the jb/releases/DE-41 branch June 18, 2025 14:41
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
This column only ever contains a single button with `View` text, meaning
we can remove the overflow: hidden rule entirely.

```
<ViewColumn>
    <GuideAnchor disabled={!isTopRelease || index !== 0} target="view_release">
      <LinkButton ...>
        {t('View')}
      </LinkButton>
    </GuideAnchor>
  </ViewColumn>
```

![CleanShot 2025-05-27 at 15 23
14@2x](https://github.com/user-attachments/assets/0a7c37a1-fe20-442b-8599-6d6f7f2168de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants