Skip to content

fix(issues): Add device.name to search suggestions #92627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

fix(issues): Add device.name to search suggestions #92627

merged 2 commits into from
Jun 16, 2025

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 2, 2025 •
edited
Loading

  • removes duplicate FieldKey.DEVICE_LOCALE
  • adds missing FieldKey.DEVICE_NAME that makes it show up in search suggestions
    image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 2, 2025
@romtsn romtsn requested review from shruthilayaj and billyvg June 2, 2025 15:12
@romtsn
Copy link
Member Author

romtsn commented Jun 2, 2025

I am not sure what's that "Descriptor details" though, maybe we should change it to something more meaningful?

billyvg
billyvg approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we should update the description for DEVICE_NAME

@romtsn
Copy link
Member Author

romtsn commented Jun 16, 2025

changed description in d48efe2

@romtsn romtsn enabled auto-merge (squash) June 16, 2025 21:33
@romtsn romtsn merged commit 77bb8f5 into master Jun 16, 2025
45 checks passed
@romtsn romtsn deleted the rz/fix/issue-device-name-suggestion branch June 16, 2025 21:42
billyvg pushed a commit that referenced this pull request Jun 18, 2025
@romtsn @billyvg
fix(issues): Add device.name to search suggestions (#92627)
dbb527f 
- removes duplicate `FieldKey.DEVICE_LOCALE`
- adds missing `FieldKey.DEVICE_NAME` that makes it show up in search
suggestions
- fixes `FieldKey.DEVICE_NAME` description

![image](https://github.com/user-attachments/assets/7d5b7579-b59c-459f-9485-f667e4ab9ac6)
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@romtsn @andrewshie-sentry
fix(issues): Add device.name to search suggestions (#92627)
f9eef4f 
- removes duplicate `FieldKey.DEVICE_LOCALE`
- adds missing `FieldKey.DEVICE_NAME` that makes it show up in search
suggestions
- fixes `FieldKey.DEVICE_NAME` description

![image](https://github.com/user-attachments/assets/7d5b7579-b59c-459f-9485-f667e4ab9ac6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@shruthilayaj shruthilayaj shruthilayaj approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romtsn @billyvg @shruthilayaj