ref: properly type Span enrichment #92970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create new Span objects from the SegmentSpan inputs rather than mutating / casting
asottile-sentry
force-pushed
the
asottile-span-enrichment-typed
branch
from
cabb59d to
5580df1
Compare
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92970 +/- ##
===========================================
+ Coverage 44.63% 85.56% +40.92%
===========================================
Files 10270 10285 +15
Lines 589689 590429 +740
Branches 22962 22962
===========================================
+ Hits 263234 505221 +241987
+ Misses 326008 84577 -241431
- Partials 447 631 +184 |
untitaker
approved these changes
Jun 11, 2025
vishnupsatish
pushed a commit
that referenced
this pull request
Jun 12, 2025
create new Span objects from the SegmentSpan inputs rather than mutating / casting <!-- Describe your PR here. -->
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
create new Span objects from the SegmentSpan inputs rather than mutating / casting <!-- Describe your PR here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create new Span objects from the SegmentSpan inputs rather than mutating / casting