🔧 chore(aci): remove workflow_id from WorkflowEventData
#93015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
approved these changes
Jun 6, 2025
iamrajjoshi
force-pushed
the
raj/map-action-to-workflow
branch
from
41f9ee8 to
4c1bd1e
Compare
iamrajjoshi
force-pushed
the
raj/rm-wfk-id-event-data
branch
from
4417588 to
f09dbc8
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93015 +/- ##
===========================================
+ Coverage 46.22% 70.94% +24.71%
===========================================
Files 10275 10289 +14
Lines 592803 593521 +718
Branches 23035 23034 -1
===========================================
+ Hits 274046 421072 +147026
+ Misses 318325 172017 -146308
Partials 432 432 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing the work from #92700
here, i remove the usage of
WorkflowEventData.workflow_idand replacing it with the usage of annotating theactionobject