Skip to content

feat(agents-insights): abbreviated trace drawer #93018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 13, 2025

Conversation

obostjancic
Copy link
Member

@obostjancic obostjancic commented Jun 6, 2025

Closes TET-577: Dashboard - Trace view drawer

Screen.Recording.2025-06-12.at.15.50.38.mov

Note: Both code and feature are WIP. It is hidden behind a feature flag like the rest of this page.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2025
@obostjancic obostjancic changed the title poc feat(agents-insights): Abbreviated trace drawer Jun 6, 2025
@obostjancic obostjancic changed the title feat(agents-insights): Abbreviated trace drawer feat(agents-insights): abbreviated trace drawer Jun 6, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93018       +/-   ##
===========================================
+ Coverage   46.23%   87.90%   +41.66%     
===========================================
  Files       10272    10293       +21     
  Lines      592455   589642     -2813     
  Branches    23033    22945       -88     
===========================================
+ Hits       273927   518296   +244369     
+ Misses     318096    70899   -247197     
- Partials      432      447       +15     

@ArthurKnaus ArthurKnaus marked this pull request as ready for review June 12, 2025 13:36
@ArthurKnaus ArthurKnaus requested review from a team as code owners June 12, 2025 13:36
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some padding issues, but none of my comments is a blocker as this is feature flagged wip. So feel free to either fix now or in a follow-up PRs 👍

CleanShot 2025-06-12 at 16 17 16

<DrawerWrapper>
<StyledDrawerHeader>
<HeaderContent>
<div>AI Mode</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would probably leave this title out (or translate it)

<div>AI Mode</div>
<LinkButton
size="xs"
to={getTraceDetailsUrl({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link to the full trace with the same span selected as in this drawer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created a task for it 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see also non-ai spans - am I doing something wrong?
I think it used to filter ai spans at one point.
CleanShot 2025-06-12 at 16 13 09

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, filtering is not yet implemented.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created a task for it 👍

@ArthurKnaus ArthurKnaus merged commit 2d12087 into master Jun 13, 2025
43 checks passed
@ArthurKnaus ArthurKnaus deleted the ogi/feat/abbreviated-trace-drawer branch June 13, 2025 07:23
billyvg pushed a commit that referenced this pull request Jun 18, 2025
Closes [TET-577: Dashboard - Trace view
drawer](https://linear.app/getsentry/issue/TET-577/dashboard-trace-view-drawer)


**Note: Both code and feature are WIP.** It is hidden behind a feature
flag like the rest of this page.

---------

Co-authored-by: Arthur Knaus <[email protected]>
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Closes [TET-577: Dashboard - Trace view
drawer](https://linear.app/getsentry/issue/TET-577/dashboard-trace-view-drawer)


**Note: Both code and feature are WIP.** It is hidden behind a feature
flag like the rest of this page.

---------

Co-authored-by: Arthur Knaus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants