-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(agents-insights): abbreviated trace drawer #93018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93018 +/- ##
===========================================
+ Coverage 46.23% 87.90% +41.66%
===========================================
Files 10272 10293 +21
Lines 592455 589642 -2813
Branches 23033 22945 -88
===========================================
+ Hits 273927 518296 +244369
+ Misses 318096 70899 -247197
- Partials 432 447 +15 |
static/app/views/insights/agentMonitoring/components/drawer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<DrawerWrapper> | ||
<StyledDrawerHeader> | ||
<HeaderContent> | ||
<div>AI Mode</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would probably leave this title out (or translate it)
<div>AI Mode</div> | ||
<LinkButton | ||
size="xs" | ||
to={getTraceDetailsUrl({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should link to the full trace with the same span selected as in this drawer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created a task for it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, filtering is not yet implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created a task for it 👍
Closes [TET-577: Dashboard - Trace view drawer](https://linear.app/getsentry/issue/TET-577/dashboard-trace-view-drawer) **Note: Both code and feature are WIP.** It is hidden behind a feature flag like the rest of this page. --------- Co-authored-by: Arthur Knaus <[email protected]>
Closes [TET-577: Dashboard - Trace view drawer](https://linear.app/getsentry/issue/TET-577/dashboard-trace-view-drawer) **Note: Both code and feature are WIP.** It is hidden behind a feature flag like the rest of this page. --------- Co-authored-by: Arthur Knaus <[email protected]>
Closes TET-577: Dashboard - Trace view drawer
Screen.Recording.2025-06-12.at.15.50.38.mov
Note: Both code and feature are WIP. It is hidden behind a feature flag like the rest of this page.