chore(github): Changes the max-width to absolute value to eliminate excess whitespace #93247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
leeandher
reviewed
Jun 10, 2025
Comment on lines
251
to
265
| const FullText = styled('span')` | ||
| display: inline; | ||
|
|
||
| @media (max-width: 768px) { | ||
| display: none; | ||
| } | ||
| `; | ||
|
|
||
| const ShortText = styled('span')` | ||
| display: none; | ||
|
|
||
| @media (max-width: 768px) { | ||
| display: inline; | ||
| } | ||
| `; |
There was a problem hiding this comment.
This isn't a great UX, especially since from the screenshot there is a huge amount of whitespace on either side. Dropdowns are already overlays so a tooltip on top is pretty unexpected.
The better solution IMO would be to remove max-width: 33px from StyledContainer and replace it with an actual px value. LMK if that fixes the issue, if not we can work through it together.
There was a problem hiding this comment.
I just tried and damn yeah it looks so much better 😭
Christinarlong
changed the title
leeandher
approved these changes
Jun 13, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…xcess whitespace (#93247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead changes the max-width to absolute value to eliminate excess whitespace - credit to leander 🙏
small screen
normal screen
