Skip to content

fix(span-buffer): Log exit code of flusher process #93320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

fix(span-buffer): Log exit code of flusher process #93320

merged 1 commit into from
Jun 12, 2025

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Jun 11, 2025 •
edited by jan-auer
Loading

Ref STREAM-209

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 11, 2025
jan-auer
jan-auer approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking - I've not tested this

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/spans/consumers/process/flusher.py 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #93320      +/-   ##
==========================================
- Coverage   87.99%   87.99%   -0.01%     
==========================================
  Files       10267    10267              
  Lines      592076   592109      +33     
  Branches    23001    23001              
==========================================
+ Hits       521025   521053      +28     
- Misses      70620    70625       +5     
  Partials      431      431

@jan-auer jan-auer marked this pull request as ready for review June 12, 2025 08:39
@jan-auer jan-auer requested review from a team as code owners June 12, 2025 08:39
@untitaker untitaker merged commit a7a906d into master Jun 12, 2025
63 checks passed
@untitaker untitaker deleted the fix/flusher-exitcode branch June 12, 2025 09:20
vishnupsatish pushed a commit that referenced this pull request Jun 12, 2025
@untitaker @vishnupsatish
fix(span-buffer): Log exit code of flusher process (#93320)
5e6c3a5 
Ref STREAM-209
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@untitaker @andrewshie-sentry
fix(span-buffer): Log exit code of flusher process (#93320)
d5da1ad 
Ref STREAM-209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @jan-auer