Skip to content

chore(dashboards): Log when the user time zone doesn't match the system time zone #93330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

gggritso
Copy link
Member

There's an issue where the chart ticks don't look right when the user's time zone doesn't match the system time zone. The fix is gnarly, so we want to figure out how often this happens, first, and why.

There are a few places in bootstrap where we import the Sentry SDK, so I assume it's fine to do it here, too.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 11, 2025
@gggritso gggritso requested a review from billyvg June 11, 2025 16:02
@gggritso gggritso marked this pull request as ready for review June 11, 2025 16:04
@@ -44,7 +47,21 @@ const storeConfig: ConfigStoreDefinition = {
// TODO(dcramer): abstract this out of ConfigStore
if (config.user) {
config.user.permissions = new Set(config.user.permissions);
moment.tz.setDefault(config.user.options.timezone);

const systemTimeZone = moment.tz.guess();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol this fn name

@gggritso gggritso merged commit afe9c18 into master Jun 12, 2025
44 checks passed
@gggritso gggritso deleted the georgegritsouk/dain-594-log-timezone-mismatch branch June 12, 2025 13:47
vishnupsatish pushed a commit that referenced this pull request Jun 12, 2025
…em time zone (#93330)

There's [an
issue](https://linear.app/getsentry/issue/DAIN-594/time-series-chart-x-axis-ticks-are-not-aligned-to-dates-when-system)
where the chart ticks don't look right when the user's time zone doesn't
match the system time zone. The fix is gnarly, so we want to figure out
how often this happens, first, and why.

There are a few places in bootstrap where we import the Sentry SDK, so I
assume it's fine to do it here, too.
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
…em time zone (#93330)

There's [an
issue](https://linear.app/getsentry/issue/DAIN-594/time-series-chart-x-axis-ticks-are-not-aligned-to-dates-when-system)
where the chart ticks don't look right when the user's time zone doesn't
match the system time zone. The fix is gnarly, so we want to figure out
how often this happens, first, and why.

There are a few places in bootstrap where we import the Sentry SDK, so I
assume it's fine to do it here, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants