fix(aci): Use filter_recently_fired_workflow_actions exclusively #93382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
There's an argument that we should've tracked the differences in outcome and validated that they are what we intend, but given the lack of validated traffic on the old implementation, I'm not sure that's worth waiting for vs just trying to make sure this is correct. |
|
Actually, I should probably remove the various lingering uses of |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93382 +/- ##
==========================================
+ Coverage 83.38% 88.07% +4.68%
==========================================
Files 10322 10311 -11
Lines 595614 594638 -976
Branches 23137 22985 -152
==========================================
+ Hits 496637 523707 +27070
+ Misses 98484 70499 -27985
+ Partials 493 432 -61 |
saponifi3d
approved these changes
Jun 17, 2025
src/sentry/incidents/endpoints/serializers/workflow_engine_detector.py
Outdated
Show resolved
Hide resolved
| @@ -7,6 +7,7 @@ | |||
| @region_silo_model | |||
| class ActionGroupStatus(DefaultFieldsModel): | |||
| """ | |||
| DEPRECATED: Use WorkflowActionGroupStatus instead. This will be removed soon. | |||
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
) Use WorkflowActionGroupStatus for our recency filtering rather than ActionGroupStatus. While we're at it, remove any remaining active uses of ActionGroupStatus. --------- Co-authored-by: Josh Callender <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
) Use WorkflowActionGroupStatus for our recency filtering rather than ActionGroupStatus. While we're at it, remove any remaining active uses of ActionGroupStatus. --------- Co-authored-by: Josh Callender <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use WorkflowActionGroupStatus for our recency filtering rather than ActionGroupStatus.
While we're at it, remove any remaining active uses of ActionGroupStatus.