fix(feedback): Apply disabled feedback logic to all input buttons and dropdowns #93383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
approved these changes
Jun 11, 2025
| : undefined, | ||
| tooltip: enableDelete | ||
| ? undefined | ||
| : t('You must be an admin to delete feedback.'), |
There was a problem hiding this comment.
i'm noticing some inconsistencies on the tooltips and whether they have a period at the end or not
aliu39
approved these changes
Jun 16, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
… dropdowns (#93383) This disables the `delete` button when the screen is normal width or narrow. And moves a bunch of logic into the hooks to try and cleanup some stuff. The original bug report was about deleting a feedback from the list view, which I still can't repro. Related to REPLAY-400
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
… dropdowns (#93383) This disables the `delete` button when the screen is normal width or narrow. And moves a bunch of logic into the hooks to try and cleanup some stuff. The original bug report was about deleting a feedback from the list view, which I still can't repro. Related to REPLAY-400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the
deletebutton when the screen is normal width or narrow. And moves a bunch of logic into the hooks to try and cleanup some stuff.The original bug report was about deleting a feedback from the list view, which I still can't repro.
Related to REPLAY-400