fix(aci milestone 3): fix migration for dual written anomaly detection alerts #93391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
reviewed
Jun 11, 2025
src/sentry/workflow_engine/migrations/0068_migrate_anomaly_detection_alerts.py
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93391 +/- ##
===========================================
+ Coverage 46.23% 88.02% +41.79%
===========================================
Files 10271 10286 +15
Lines 592532 593406 +874
Branches 23034 23022 -12
===========================================
+ Hits 273933 522367 +248434
+ Misses 318167 70607 -247560
Partials 432 432 |
iamrajjoshi
approved these changes
Jun 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…n alerts (#93391) Alerts that are dual written + alerts whose data conditions were fixed in the first attempt at the migration do not have data conditions that need to be updated. Check for the anomaly detection data condition and skip if it was found. Also introduce a try-catch to the update method so that future errors don't pause the migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alerts that are dual written + alerts whose data conditions were fixed in the first attempt at the migration do not have data conditions that need to be updated. Check for the anomaly detection data condition and skip if it was found. Also introduce a try-catch to the update method so that future errors don't pause the migration.