Skip to content

build: run rspack in ESM with Node v22.16 #93392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025
Merged

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 11, 2025

Fixes build issue in Node v22.16.0 by running rspack in ESM mode.

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jun 11, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff               @@
##           jb/node/24   #93392      +/-   ##
==============================================
- Coverage       87.26%   86.06%   -1.21%     
==============================================
  Files           10331    10331              
  Lines          593213   593229      +16     
  Branches        22956    22956              
==============================================
- Hits           517691   510537    -7154     
- Misses          75086    82256    +7170     
  Partials          436      436              

@JonasBa JonasBa changed the title deps: bump node to v24 build: run rspack in ESM with Node v22.16 Jun 16, 2025
@JonasBa JonasBa marked this pull request as ready for review June 16, 2025 15:47
@JonasBa JonasBa requested review from a team as code owners June 16, 2025 15:47
@JonasBa JonasBa requested a review from a team June 16, 2025 15:48
@JonasBa JonasBa force-pushed the jb/node/tsconfig-split branch from a597ac3 to 305485c Compare June 16, 2025 15:56
@JonasBa JonasBa merged commit 976d002 into jb/node/24 Jun 16, 2025
38 checks passed
@JonasBa JonasBa deleted the jb/node/tsconfig-split branch June 16, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants