ref(grouping): Disallow setting grouping config using API #93393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93393 +/- ##
==========================================
+ Coverage 84.34% 88.00% +3.65%
==========================================
Files 10288 10288
Lines 593175 593153 -22
Branches 23031 23031
==========================================
+ Hits 500301 521986 +21685
+ Misses 92442 70735 -21707
Partials 432 432 |
lobsterkatie
force-pushed
the
kmclb-disallow-setting-grouping-config-via-API
branch
from
33f7cd3 to
3b9f0bb
Compare
mrduncan
approved these changes
Jun 12, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
In the past, grouping config was an option that could be set in project settings. The project details endpoint therefore accepted `groupingConfig`, `secondaryGroupingConfig`, and `secondaryGroupingExpiry` as things you could change via the API. Now that that's no longer the case, we don't need this ability, and having it just allows users to shoot themselves in the foot by setting an invalid value. This therefore removes the ability to set those values via API. Just in case some customer has a script which does this, for now the endpoint returns option-specific validation errors. Eventually we can probably remove those, though.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
In the past, grouping config was an option that could be set in project settings. The project details endpoint therefore accepted `groupingConfig`, `secondaryGroupingConfig`, and `secondaryGroupingExpiry` as things you could change via the API. Now that that's no longer the case, we don't need this ability, and having it just allows users to shoot themselves in the foot by setting an invalid value. This therefore removes the ability to set those values via API. Just in case some customer has a script which does this, for now the endpoint returns option-specific validation errors. Eventually we can probably remove those, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, grouping config was an option that could be set in project settings. The project details endpoint therefore accepted
groupingConfig,secondaryGroupingConfig, andsecondaryGroupingExpiryas things you could change via the API. Now that that's no longer the case, we don't need this ability, and having it just allows users to shoot themselves in the foot by setting an invalid value.This therefore removes the ability to set those values via API. Just in case some customer has a script which does this, for now the endpoint returns option-specific validation errors. Eventually we can probably remove those, though.