Skip to content

perf(aci): Cache Environment lookup to avoid db queries #93400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Conversation

kcons
Copy link
Member

@kcons kcons commented Jun 12, 2025

Rather than load them from the Workflow where query avoidance is dependent on if earlier interactions fetched them, we load them from the cache where we'll generally expect them to be very quickly available.

Copy link

sentry-io bot commented Jun 12, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/workflow_engine/processors/workflow.py

Function Unhandled Issue
evaluate_workflows_action_filters SoftTimeLimitExceeded: SoftTimeLimitExceeded('SoftTimeLimitExceeded()\nSQL: SELECT "workflow_engine_detector"."id", "workflow_engine_detector"."date_updated", "workflow_engine_detector"."date_added", "workflow_engine_detector"."config", "workflow_engine_detector"."owner_user_... ...
Event Count: 4

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2025
@kcons kcons marked this pull request as ready for review June 12, 2025 15:53
@kcons kcons requested a review from a team as a code owner June 12, 2025 15:53
@kcons kcons merged commit bbc49b4 into master Jun 12, 2025
62 checks passed
@kcons kcons deleted the kcons/cacheenv branch June 12, 2025 17:19
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Rather than load them from the Workflow where query avoidance is
dependent on if earlier interactions fetched them, we load them from the
cache where we'll generally expect them to be very quickly available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants