fix(platform-insights): Use different param name for table cursor #93407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
shellmayr
approved these changes
Jun 12, 2025
ArthurKnaus
deleted the
arthurknaus/tet-629-web-vitals-widget-resets-when-paginating
branch
vishnupsatish
pushed a commit
that referenced
this pull request
Jun 12, 2025
…3407) ### Problem As `useEAPSpans` creates an `EventView` internally, it picks up the `cursor` param from the url and passes it to the requests. Therefore changing the page on the table which uses the `cursor` param for pagination updates all widgets that use `useEAPSpans`. On some the underlying logic does not expect that and results in a broken visualization (e.g. web witals widget). ### Solution As it is not clear whether the behavior of `useEAPSpans` is intentional, we can simply updated the name of the table's cursor param to `tableCursor` - closes [TET-629: Web Vitals widget resets when paginating](https://linear.app/getsentry/issue/TET-629/web-vitals-widget-resets-when-paginating)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…3407) ### Problem As `useEAPSpans` creates an `EventView` internally, it picks up the `cursor` param from the url and passes it to the requests. Therefore changing the page on the table which uses the `cursor` param for pagination updates all widgets that use `useEAPSpans`. On some the underlying logic does not expect that and results in a broken visualization (e.g. web witals widget). ### Solution As it is not clear whether the behavior of `useEAPSpans` is intentional, we can simply updated the name of the table's cursor param to `tableCursor` - closes [TET-629: Web Vitals widget resets when paginating](https://linear.app/getsentry/issue/TET-629/web-vitals-widget-resets-when-paginating)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As
useEAPSpanscreates anEventViewinternally, it picks up thecursorparam from the url and passes it to the requests. Therefore changing the page on the table which uses thecursorparam for pagination updates all widgets that useuseEAPSpans. On some the underlying logic does not expect that and results in a broken visualization (e.g. web witals widget).Solution
As it is not clear whether the behavior of
useEAPSpansis intentional, we can simply updated the name of the table's cursor param totableCursor