fix(agent-insights): Filter empty input messages #93409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
vgrozdanic
approved these changes
Jun 12, 2025
shellmayr
reviewed
Jun 12, 2025
Comment on lines
-25
to
-28
| return content | ||
| .filter((part: any) => part.type === 'text') | ||
| .map((part: any) => part.text) | ||
| .join('\n'); |
There was a problem hiding this comment.
why is this part not needed anymore?
There was a problem hiding this comment.
code de-duplication. renderUserMessage & renderAssistantMessage became renderTextMessages
There was a problem hiding this comment.
yeah that part I saw, but I mean the filter().map().join()
There was a problem hiding this comment.
It is still doing it?
function renderTextMessages(content: any) {
if (!Array.isArray(content)) {
return content;
}
return content
.filter((part: any) => part.type === 'text')
.map((part: any) => part.text)
.join('\n');
}There was a problem hiding this comment.
Oh, sorry, I read that diff wrong - looked like we were just returning content. Thanks for clarifying :)
shellmayr
approved these changes
Jun 12, 2025
ArthurKnaus
deleted the
aknaus/fix/agent-insights/filter-empty-input-messages
branch
vishnupsatish
pushed a commit
that referenced
this pull request
Jun 12, 2025
Sometimes we receive messages with not renderable content. This PR filters those messages.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sometimes we receive messages with not renderable content. This PR filters those messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we receive messages with not renderable content.
This PR filters those messages.