feat(dynamic-sampling): add project option for dynamic sampling minimum sample rate #93411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
vgrozdanic
approved these changes
Jun 12, 2025
| raise serializers.ValidationError( | ||
| "Organization does not have the dynamic sampling minimum sample rate feature enabled." | ||
| ) | ||
| return value |
There was a problem hiding this comment.
Do we also want to perform a validation that the value is in allowed range?
There was a problem hiding this comment.
Ah yeah, forgot to push the test for that - this is already done by virtue of that field being a BooleanField
There was a problem hiding this comment.
Ahh yeah, my bad, sorry, for some reason i though this is a float field 🙈
shellmayr
deleted the
shellmayr/tet-566-provide-backend-to-store-user-per-project-choice-for-minimum-v2
branch
vishnupsatish
pushed a commit
that referenced
this pull request
Jun 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentry:dynamic_sampling_minimum_sample_ratewith a default value ofFalse.PUTmethod inProjectDetailsEndpointto allow updates to thedynamicSamplingMinimumSampleRatefield and reflect changes in project settings.DetailedProjectResponseto include thedynamicSamplingMinimumSampleRatefield and ensure it is serialized correctly based on the feature flag and project settings.