Skip to content

fix(referrers): Use main list of referrers to validate #93427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 13, 2025

Conversation

Zylphrex
Copy link
Member

These per endpoint lists are starting to converge to the main list. No real point in maintaining them separately. So just use the main referrers list to validate it.

These per endpoint lists are starting to converge to the main list. No real
point in maintaining them separately. So just use the main referrers list to
validate it.
@Zylphrex Zylphrex requested a review from a team as a code owner June 12, 2025 14:17
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2025
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ry/api/endpoints/organization_events_timeseries.py 62.50% 3 Missing ⚠️
src/sentry/snuba/referrer.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93427       +/-   ##
===========================================
+ Coverage   51.29%   88.02%   +36.72%     
===========================================
  Files       10263    10293       +30     
  Lines      592629   593746     +1117     
  Branches    23035    23030        -5     
===========================================
+ Hits       304012   522663   +218651     
+ Misses     288185    70649   -217536     
- Partials      432      434        +2     

@Zylphrex Zylphrex enabled auto-merge (squash) June 13, 2025 14:08
@Zylphrex Zylphrex merged commit f39a2b5 into master Jun 13, 2025
64 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/use-main-list-of-referrers-to-validate branch June 13, 2025 14:20
billyvg pushed a commit that referenced this pull request Jun 18, 2025
These per endpoint lists are starting to converge to the main list. No
real point in maintaining them separately. So just use the main
referrers list to validate it.
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
These per endpoint lists are starting to converge to the main list. No
real point in maintaining them separately. So just use the main
referrers list to validate it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants