Skip to content

feat(explore): Start storing explore saved queries using aggregate fi… #93429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Zylphrex
Copy link
Member

…elds

Storing it in aggregate fields allows us to preserve the order of the columns.

…elds

Storing it in aggregate fields allows us to preserve the order of the columns.
@Zylphrex Zylphrex requested a review from a team as a code owner June 12, 2025 15:02
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 12, 2025
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93429       +/-   ##
===========================================
+ Coverage   46.37%   85.80%   +39.42%     
===========================================
  Files       10309    10287       -22     
  Lines      594899   592836     -2063     
  Branches    23130    22998      -132     
===========================================
+ Hits       275905   508688   +232783     
+ Misses     318501    83540   -234961     
- Partials      493      608      +115     

Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing popped out to me, looks good otherwise 👍

@Zylphrex Zylphrex merged commit f17245d into master Jun 16, 2025
46 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/start-storing-explore-saved-queries-using-aggregate-fields branch June 16, 2025 19:41
billyvg pushed a commit that referenced this pull request Jun 18, 2025
#93429)

…elds

Storing it in aggregate fields allows us to preserve the order of the
columns.
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
#93429)

…elds

Storing it in aggregate fields allows us to preserve the order of the
columns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants