fix(uptime): ensure we don't count interval changes as missed checks #93441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
approved these changes
Jun 12, 2025
klochek
deleted the
christopherklochek/new-419-fix-false-positives-when-detecting-missing-checks-in-uptime
branch
vishnupsatish
pushed a commit
that referenced
this pull request
Jun 12, 2025
…93441) If a user changes the checkin interval, we might see this in uptime_consumer as a potential missed checkin. Add a key to redis that stores the last seen interval, and use that to compare with the interval from postgres. Note that we don't store the interval constantly, just in the case that we see a difference in interval, so we might miss an actual missed check if it's the first apparent missed check we've seen for a subscription.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…93441) If a user changes the checkin interval, we might see this in uptime_consumer as a potential missed checkin. Add a key to redis that stores the last seen interval, and use that to compare with the interval from postgres. Note that we don't store the interval constantly, just in the case that we see a difference in interval, so we might miss an actual missed check if it's the first apparent missed check we've seen for a subscription.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user changes the checkin interval, we might see this in uptime_consumer as a potential missed checkin. Add a key to redis that stores the last seen interval, and use that to compare with the interval from postgres. Note that we don't store the interval constantly, just in the case that we see a difference in interval, so we might miss an actual missed check if it's the first apparent missed check we've seen for a subscription.