fix(billing): Exclude trial budgets in product select analytics #93446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93446 +/- ##
==========================================
- Coverage 88.00% 78.24% -9.76%
==========================================
Files 10287 10287
Lines 593304 593304
Branches 23034 23034
==========================================
- Hits 522126 464245 -57881
- Misses 70746 128627 +57881
Partials 432 432 |
dashed
approved these changes
Jun 12, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
When setting `previously_enabled` for a selectable product, we only checked that they had a reserved budget for that product above 0, but this didn't take into account reserved budgets from trial plans. This led to false positives when checking for Seer Disabled events, as these were orgs who were on trial plans who upgraded to a paid plan but didn't buy Seer.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
When setting `previously_enabled` for a selectable product, we only checked that they had a reserved budget for that product above 0, but this didn't take into account reserved budgets from trial plans. This led to false positives when checking for Seer Disabled events, as these were orgs who were on trial plans who upgraded to a paid plan but didn't buy Seer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
previously_enabledfor a selectable product, we only checked that they had a reserved budget for that product above 0, but this didn't take into account reserved budgets from trial plans. This led to false positives when checking for Seer Disabled events, as these were orgs who were on trial plans who upgraded to a paid plan but didn't buy Seer.