perf(aci): Pass DataConditionGroup to process_data_condition_group #93449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/sentry/workflow_engine/processors/data_condition_group.py
📄 File: src/sentry/workflow_engine/processors/workflow.py (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
saponifi3d
approved these changes
Jun 12, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93449 +/- ##
===========================================
+ Coverage 46.23% 87.99% +41.76%
===========================================
Files 10271 10275 +4
Lines 592532 592995 +463
Branches 23034 23034
===========================================
+ Hits 273929 521803 +247874
+ Misses 318171 70760 -247411
Partials 432 432 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…93449) The caches sometimes work for us, but when they don't DataConditionGroup loads are a major contributor to query time. Making `process_data_condition_group` take a DataConditionGroup rather than an ID allow us to pass the one we have and avoid any querying risk while being roughly the same in cases where we don't have one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caches sometimes work for us, but when they don't DataConditionGroup loads are a major contributor to query time.
Making
process_data_condition_grouptake a DataConditionGroup rather than an ID allow us to pass the one we have and avoid any querying risk while being roughly the same in cases where we don't have one.