fix(insights): Prevent backend overview widgets from growing out of control #93451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows grid cell children to obey the `height: 100%` rule correctly.
github-actions
bot
added
the
Scope: Frontend
DominikB2014
approved these changes
Jun 12, 2025
gggritso
deleted the
georgegritsouk/dain-629-charts-with-footers-grow-uncontrollably-in-height-in-some
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…ontrol (#93451) Closes [DAIN-629: Charts with footers grow uncontrollably in height in some cases](https://linear.app/getsentry/issue/DAIN-629/charts-with-footers-grow-uncontrollably-in-height-in-some-cases). Sets the three-widget grid height via row height rather than overall height. This allows grid cell children to obey the `height: 100%` rule correctly. The widgets are overflowing their parents by a fraction of a pixel, because their heights are set with height: 100%. This doesn't work in a CSS grid context! The overflow causes ECharts to detect a resize, which sets the ECharts element to a pixel height without a fraction, which increases the widgets height, which causes a resize, and so on. Note: This reveals _another_ heinous bug to be fixed separately, tracked in DAIN-630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DAIN-629: Charts with footers grow uncontrollably in height in some cases. Sets the three-widget grid height via row height rather than overall height. This allows grid cell children to obey the
height: 100%rule correctly. The widgets are overflowing their parents by a fraction of a pixel, because their heights are set with height: 100%. This doesn't work in a CSS grid context! The overflow causes ECharts to detect a resize, which sets the ECharts element to a pixel height without a fraction, which increases the widgets height, which causes a resize, and so on.Note: This reveals another heinous bug to be fixed separately, tracked in DAIN-630