fix(insights): Prevent duplicate rows in footer of Slow Queries widget #93453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`!!([])` evaluates to `true`, so this query is _always_ enabled. We need to check the length of the response instead.
github-actions
bot
added
the
Scope: Frontend
gggritso
deleted the
georgegritsouk/dain-630-widget-footers-incorrectly-render-duplicate-rows-when
branch
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
#93453) Closes [DAIN-630: Widget footers incorrectly render duplicate rows when changing filters](https://linear.app/getsentry/issue/DAIN-630/widget-footers-incorrectly-render-duplicate-rows-when-changing-filters). There were two errors: 1. The `enabled: ` check wasn't working correctly. `data` is _always_ an array, and `!!([])` evalues to `true` so the query was always enabled. This causes an extra query with no conditions to fire every time the filters change 2. The `key` of the items in the footer was not unique, since multiple spans of the same normalized description can come back between requests and between renders. Duplicate keys can cause duplicate items in the list in some cases (like this case) This PR fixes both those errors. This is a little tough to see locally since it's obscured by DAIN-629.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
#93453) Closes [DAIN-630: Widget footers incorrectly render duplicate rows when changing filters](https://linear.app/getsentry/issue/DAIN-630/widget-footers-incorrectly-render-duplicate-rows-when-changing-filters). There were two errors: 1. The `enabled: ` check wasn't working correctly. `data` is _always_ an array, and `!!([])` evalues to `true` so the query was always enabled. This causes an extra query with no conditions to fire every time the filters change 2. The `key` of the items in the footer was not unique, since multiple spans of the same normalized description can come back between requests and between renders. Duplicate keys can cause duplicate items in the list in some cases (like this case) This PR fixes both those errors. This is a little tough to see locally since it's obscured by DAIN-629.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DAIN-630: Widget footers incorrectly render duplicate rows when changing filters. There were two errors:
enabled:check wasn't working correctly.datais always an array, and!!([])evalues totrueso the query was always enabled. This causes an extra query with no conditions to fire every time the filters changekeyof the items in the footer was not unique, since multiple spans of the same normalized description can come back between requests and between renders. Duplicate keys can cause duplicate items in the list in some cases (like this case)This PR fixes both those errors. This is a little tough to see locally since it's obscured by DAIN-629.