fix(dashboards-comparison): Record all fields as mismatches on request failure #93454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
nikkikapadia
commented
Jun 12, 2025
| @@ -263,7 +263,7 @@ def compare_tables_for_dashboard_widget_queries( | |||
| "reason": CompareTableResult.EAP_FAILED, | |||
| "fields": fields, | |||
| "widget_query": widget_query, | |||
| "mismatches": None, | |||
| "mismatches": fields, | |||
There was a problem hiding this comment.
should i be returning when metrics fail too? I assumed not because metrics failing doesn't necessarily mean there's a mismatch
shruthilayaj
approved these changes
Jun 12, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
…t failure (#93454) I realized eap failing is a sign of a mismatch (for things like user_misery and apdex) so i'm returning it to make sure it gets documented in the final sentry message in the job
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…t failure (#93454) I realized eap failing is a sign of a mismatch (for things like user_misery and apdex) so i'm returning it to make sure it gets documented in the final sentry message in the job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized eap failing is a sign of a mismatch (for things like user_misery and apdex) so i'm returning it to make sure it gets documented in the final sentry message in the job