Skip to content

feat(feedback): cache the feedback summary #93461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 18, 2025
Merged

feat(feedback): cache the feedback summary #93461

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a3fc015
oops
vishnupsatish Jun 12, 2025
bdb0377
tests
vishnupsatish Jun 12, 2025
f872d57
figure out what filters to add
vishnupsatish Jun 13, 2025
67f2baa
change cache key and strategy
vishnupsatish Jun 13, 2025
ec7ddc4
store number of feedbacks used in the cache
vishnupsatish Jun 13, 2025
f8007ed
update based on review
vishnupsatish Jun 13, 2025
fb62333
better variable names
vishnupsatish Jun 16, 2025
7357540
add hour granularity to the cache key and timeout after one day
vishnupsatish Jun 16, 2025
56af2a3
resolve conflicts
vishnupsatish Jun 17, 2025
3faa504
remove comment
vishnupsatish Jun 17, 2025
4ded97d
Merge remote-tracking branch 'origin/master' into vishnupsatish/uf-su…
vishnupsatish Jun 17, 2025
a2c21d3
Merge remote-tracking branch 'origin/master' into vishnupsatish/uf-su…
vishnupsatish Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment
  • Loading branch information
@vishnupsatish
vishnupsatish committed Jun 17, 2025
commit 3faa50458f38cb15443afe3b9632f4820dda63ac
1 change: 0 additions & 1 deletion src/sentry/api/endpoints/organization_feedback_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ def get(self, request: Request, organization: Organization) -> Response:
project_ids = [str(project_id) for project_id in numeric_project_ids]
hashed_project_ids = hash_from_values(project_ids)

# Cache key should be the filters that were selected by the user, start and end dates at hour granularity
summary_cache_key = f"feedback_summary:{organization.id}:{start.strftime('%Y-%m-%d-%H')}:{end.strftime('%Y-%m-%d-%H')}:{hashed_project_ids}"
summary_cache = cache.get(summary_cache_key)
if summary_cache:
Expand Down
Loading