fix(workflow_engine): Fix action metrics while in dual processing #93464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
approved these changes
Jun 12, 2025
saponifi3d
force-pushed
the
jcallender/aci/fix-action-metric
branch
from
59ea9dc to
aec4ea1
Compare
cathteng
reviewed
Jun 12, 2025
| @@ -309,6 +309,14 @@ def process_workflows(event_data: WorkflowEventData) -> set[Workflow]: | |||
| "event_data": asdict(event_data), | |||
| }, | |||
| ) | |||
| else: | |||
| # If the feature flag is not enabled, only send a metric | |||
| for action in actions: | |||
There was a problem hiding this comment.
can we log all the action ids that were triggered by an event?
There was a problem hiding this comment.
doh, sorry this was auto merged. can +1 a PR or add to another. (lemme know which)
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
…3464) # Description Moved the `metrics_incr` to after the action has been triggered, which broke our current dashboards. This will reintroduce a metric `workflow_engine.process_workflows.action_triggered` -- with the tag that includes the type of action we would have triggered.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…3464) # Description Moved the `metrics_incr` to after the action has been triggered, which broke our current dashboards. This will reintroduce a metric `workflow_engine.process_workflows.action_triggered` -- with the tag that includes the type of action we would have triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved the
metrics_incrto after the action has been triggered, which broke our current dashboards.This will reintroduce a metric
workflow_engine.process_workflows.action_triggered-- with the tag that includes the type of action we would have triggered.