Skip to content

feat(preprod): Perform actual extras column drop #93466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025

Conversation

trevor-e
Copy link
Member

@trevor-e trevor-e commented Jun 12, 2025

Second step of the plan in #93388

Won't merge until the first PR is fully deployed.

@trevor-e trevor-e requested a review from a team as a code owner June 12, 2025 18:15
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2025
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0003_drop_sentry_jsonfield_actual.py

for 0003_drop_sentry_jsonfield_actual in preprod

--
-- Remove field extras from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "extras" CASCADE;

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93466      +/-   ##
==========================================
+ Coverage   88.00%   88.04%   +0.04%     
==========================================
  Files       10316    10308       -8     
  Lines      594501   594096     -405     
  Branches    23086    23013      -73     
==========================================
- Hits       523166   523051     -115     
+ Misses      70886    70613     -273     
+ Partials      449      432      -17     

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevor-e trevor-e merged commit 04b3441 into master Jun 13, 2025
64 checks passed
@trevor-e trevor-e deleted the telkins/jsonfield-drop branch June 13, 2025 16:33
trevor-e added a commit that referenced this pull request Jun 13, 2025
The final PR in our saga to change the type of `extras` ->
`models.JSONField`. This simply adds back the column.

See #93466 and
#93388
billyvg pushed a commit that referenced this pull request Jun 18, 2025
Second step of the plan in
#93388

Won't merge until the first PR is fully deployed.
billyvg pushed a commit that referenced this pull request Jun 18, 2025
The final PR in our saga to change the type of `extras` ->
`models.JSONField`. This simply adds back the column.

See #93466 and
#93388
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Second step of the plan in
#93388

Won't merge until the first PR is fully deployed.
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
The final PR in our saga to change the type of `extras` ->
`models.JSONField`. This simply adds back the column.

See #93466 and
#93388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants