-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(preprod): Perform actual extras column drop #93466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has a migration; here is the generated SQL for for --
-- Remove field extras from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "extras" CASCADE; |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93466 +/- ##
==========================================
+ Coverage 88.00% 88.04% +0.04%
==========================================
Files 10316 10308 -8
Lines 594501 594096 -405
Branches 23086 23013 -73
==========================================
- Hits 523166 523051 -115
+ Misses 70886 70613 -273
+ Partials 449 432 -17 |
asottile-sentry
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trevor-e
added a commit
that referenced
this pull request
Jun 13, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
Second step of the plan in #93388 Won't merge until the first PR is fully deployed.
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Second step of the plan in #93388 Won't merge until the first PR is fully deployed.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second step of the plan in #93388
Won't merge until the first PR is fully deployed.