Skip to content

chore: Initialize Sentry SDK before the config store #93471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2025
Merged

chore: Initialize Sentry SDK before the config store #93471

merged 3 commits into from
Jun 13, 2025

Conversation

gggritso
Copy link
Member

This allows us to log warnings during config store initialization. Config store initialization technically mutates the user config, but the SDK initialization doesn't seem to rely on that data.

@gggritso
Initialize SDK before the config store
4130b47 
This allows us to log warnings during config store initialization.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 12, 2025
@gggritso
Mutate more sanely
47c8536 
Consistently mutate `this.state` rather than the `config` object which
then also mutates the state.
@gggritso gggritso marked this pull request as ready for review June 13, 2025 17:59
@gggritso
Copy link
Member Author

There's a bunch of good potential follow-up here:

  1. Maybe separate types for JSON config and the store config
  2. Maybe create a valid store config in the Django template right away, instead of doing the Set shenanigans later
  3. Maybe pass the specific parts of the config to initializeSDK so it's clear which parts are needed and which ones might be mutated
  4. Remove the mutation, lift that logic higher up

@gggritso gggritso merged commit 1c50a2b into master Jun 13, 2025
43 checks passed
@gggritso gggritso deleted the georgegritsouk/dain-594-move-sdk-initialization-up branch June 13, 2025 18:02
billyvg pushed a commit that referenced this pull request Jun 18, 2025
@gggritso @billyvg
chore: Initialize Sentry SDK before the config store (#93471)
f3d4af1 
This allows us to log warnings during config store initialization.
Config store initialization technically mutates the user config, but the
SDK initialization doesn't seem to rely on that data.
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@gggritso @andrewshie-sentry
chore: Initialize Sentry SDK before the config store (#93471)
fee263b 
This allows us to log warnings during config store initialization.
Config store initialization technically mutates the user config, but the
SDK initialization doesn't seem to rely on that data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gggritso @billyvg