feat(cursor): Update react tests cursor rule with information from the dev docs #93472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.cursor/rules/tsx_tests.mdc
Outdated
Comment on lines
39
to
40
| screen.getByRole('button', { name: /save/i }) | ||
| screen.getByRole('textbox', { name: /search/i }) |
There was a problem hiding this comment.
Can we not give examples with regex, prefer the whole labels instead?
.cursor/rules/tsx_tests.mdc
Outdated
Comment on lines
45
to
46
| screen.getByLabelText(/email address/i) | ||
| screen.getByPlaceholderText(/enter search term/i) |
There was a problem hiding this comment.
same here, otherwise we're going to end up with a lot of regex searching
There was a problem hiding this comment.
We can tell it "if the string is dynamic, you can use regex"
There was a problem hiding this comment.
I just went ahead and removed any references to the regex, I haven't seen any issues with it so far so probably not necessary
dashed
approved these changes
Jun 12, 2025
|
Thanks! |
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
…e dev docs (#93472) Cursor has not been very good at writing frontend tests in this codebase (often mocking way too much and not using correct conventions). I'm hoping by converting some of the info we have on develop.sentry.dev over to cursor rules we can get better quality tests out of it.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…e dev docs (#93472) Cursor has not been very good at writing frontend tests in this codebase (often mocking way too much and not using correct conventions). I'm hoping by converting some of the info we have on develop.sentry.dev over to cursor rules we can get better quality tests out of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cursor has not been very good at writing frontend tests in this codebase (often mocking way too much and not using correct conventions). I'm hoping by converting some of the info we have on develop.sentry.dev over to cursor rules we can get better quality tests out of it.