ref(deletion): Simplify finding Group deletion errors #93511
Conversation
This will remove the need for extra logging.
github-actions
bot
added
the
Scope: Backend
| @@ -68,6 +68,8 @@ def delete_group_list( | |||
| { | |||
| "project_id": project.id, | |||
| "transaction_id": transaction_id, | |||
There was a problem hiding this comment.
I have managed to use Discover and transaction_id to find an error, however, it requires doing various Redash queries and GCP searches. This will remove the need of all the added logging.
| @@ -68,6 +68,8 @@ def delete_group_list( | |||
| { | |||
| "project_id": project.id, | |||
| "transaction_id": transaction_id, | |||
| "group_deletion_project_id": project.id, | |||
| "group_deletion_group_ids": group_ids, | |||
There was a problem hiding this comment.
I don't think group_deletion_group_ids is going to work as expected, tag values are always strings. group_deletion_project_id is also the same value as project_id, is that intentional?
There was a problem hiding this comment.
It is intentional. Starting with group_deletion_ is clearer.
I have updated group_ids to be a string. Thanks for catching that!
I want to avoid GCP altogether |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93511 +/- ##
==========================================
+ Coverage 86.70% 88.00% +1.29%
==========================================
Files 10305 10316 +11
Lines 594364 594501 +137
Branches 23086 23086
==========================================
+ Hits 515324 523161 +7837
+ Misses 78591 70891 -7700
Partials 449 449 |
This will remove the need for extra logging.
This will remove the need for extra logging.
This will remove the need for extra logging.