Skip to content

ref: remove PickledObjectField from Authenticator model #93515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team as code owners June 13, 2025 15:46
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 13, 2025
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0927_no_pickle_authenticator.py

for 0927_no_pickle_authenticator in sentry

--
-- Alter field config on authenticator
--
-- (no-op)

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93515   +/-   ##
=======================================
  Coverage   88.01%   88.02%           
=======================================
  Files       10326    10325    -1     
  Lines      595626   595641   +15     
  Branches    23126    23126           
=======================================
+ Hits       524268   524288   +20     
+ Misses      70865    70860    -5     
  Partials      493      493           

@asottile-sentry asottile-sentry force-pushed the asottile-authenticator-no-pickle-model branch from 3e8bad4 to b9657ec Compare June 13, 2025 16:12
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 13, 2025 16:12
@asottile-sentry asottile-sentry force-pushed the asottile-authenticator-no-pickle-model branch from b9657ec to 7a5df92 Compare June 13, 2025 17:50
@asottile-sentry asottile-sentry force-pushed the asottile-authenticator-no-pickle-model branch from 7a5df92 to a59ee5e Compare June 13, 2025 19:12
@asottile-sentry asottile-sentry marked this pull request as draft June 14, 2025 23:38
@asottile-sentry asottile-sentry force-pushed the asottile-authenticator-no-pickle-model branch from a59ee5e to a20eaa6 Compare June 16, 2025 17:09
Copy link
Contributor

github-actions bot commented Jun 16, 2025

This PR has a migration; here is the generated SQL for src/sentry/migrations/0929_no_pickle_authenticator.py

for 0929_no_pickle_authenticator in sentry

--
-- Alter field config on authenticator
--
-- (no-op)
--
-- Raw SQL operation
--

            ALTER TABLE auth_authenticator ALTER COLUMN config TYPE jsonb USING config::jsonb;

@asottile-sentry asottile-sentry force-pushed the asottile-authenticator-no-pickle-model branch from c5c84b7 to 0b63927 Compare June 16, 2025 17:55
@asottile-sentry asottile-sentry merged commit 56cf784 into master Jun 16, 2025
64 checks passed
@asottile-sentry asottile-sentry deleted the asottile-authenticator-no-pickle-model branch June 16, 2025 18:18
billyvg pushed a commit that referenced this pull request Jun 18, 2025
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants