ref(replays): Clean up RRWeb event parsing logic #93517
Merged
+381
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbs.py Co-authored-by: Andrew Liu <[email protected]>
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93517 +/- ##
==========================================
- Coverage 88.02% 88.02% -0.01%
==========================================
Files 10331 10329 -2
Lines 596378 596143 -235
Branches 23160 23107 -53
==========================================
- Hits 524976 524737 -239
- Misses 70946 70957 +11
+ Partials 456 449 -7 |
billyvg
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
For reference, here are the types as defined by the SDK: https://github.com/getsentry/sentry-javascript/blob/1ef780751a3fd895ada82164344e1aa7e9e0acb0/packages/replay-internal/src/types/replayFrame.ts
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
As we mess around with extracting data from RRWeb we need more robust methods of handling the data. The previous code was adhoc and was breakable given a sufficiently motivated person wanted to break it. It didn't break because the SDK has a limited range of event-formats it provides but that does not imply that no one could send bad events in the future. We naively parse the events and if parsing fails we handled the exception. --------- Co-authored-by: Andrew Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we mess around with extracting data from RRWeb we need more robust methods of handling the data. The previous code was adhoc and was breakable given a sufficiently motivated person wanted to break it. It didn't break because the SDK has a limited range of event-formats it provides but that does not imply that no one could send bad events in the future.
We naively parse the events and if parsing fails we handled the exception.