fix(aci): Don't propagate traces to buffer processing tasks #93521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
saponifi3d
approved these changes
Jun 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93521 +/- ##
===========================================
+ Coverage 77.84% 88.00% +10.16%
===========================================
Files 10316 10319 +3
Lines 594670 594699 +29
Branches 23129 23129
===========================================
+ Hits 462892 523377 +60485
+ Misses 131285 70829 -60456
Partials 493 493 |
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
We don't have any real need for parent or peer traces in these tasks, and not propagating should leave us with dramatically smaller traces that will load much more quickly and be easier to read. Note that this affects delayed_workflow and delayed_processing; delayed_workflow is the one we've had more issues loading, but I don't see it as having significant downside for either so I didn't make it conditional by task.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
We don't have any real need for parent or peer traces in these tasks, and not propagating should leave us with dramatically smaller traces that will load much more quickly and be easier to read. Note that this affects delayed_workflow and delayed_processing; delayed_workflow is the one we've had more issues loading, but I don't see it as having significant downside for either so I didn't make it conditional by task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have any real need for parent or peer traces in these tasks, and not propagating should leave us with dramatically smaller traces that will load much more quickly and be easier to read.
Note that this affects delayed_workflow and delayed_processing; delayed_workflow is the one we've had more issues loading, but I don't see it as having significant downside for either so I didn't make it conditional by task.