ref(js): Remove acceptance test env and related code #93538
+7
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
changed the title
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
❌ 7 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…ed-components-f1ec
scttcper
reviewed
Jun 17, 2025
Comment on lines
-23
to
-28
| return { | ||
| delay: 0, | ||
| staggerChildren: 0, | ||
| type: false, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
pretty sure jest tests use this
There was a problem hiding this comment.
will make tests that open drawers or modals slower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IS_ACCEPTANCE_TESTand its associated dynamic text/static text behavior were removed from the codebase.Changes include:
IS_ACCEPTANCE_TESTconstant was removed fromstatic/app/constants/index.tsx.rspack.config.tsandconfig/build-chartcuterie.tswere updated to remove references toIS_ACCEPTANCE_TEST.getDynamicTextutility instatic/app/utils/getDynamicText.tsxwas simplified to always return thevalueparameter, eliminating the conditionalfixedtext behavior. Its corresponding test file,static/app/utils/getDynamicText.spec.tsx, was deleted.testableTransitionutility instatic/app/utils/testableTransition.tsxwas simplified to always return the provided transition, removing logic that conditionally disabled animations for acceptance tests.useResizablehook and related constants (SECONDARY_SIDEBAR_MIN_WIDTH,SECONDARY_SIDEBAR_MAX_WIDTH) were removed, simplifyingstatic/app/views/nav/secondary/secondarySidebar.tsxandstatic/app/views/nav/sidebar.tsx.deprecateTransactionAlertswas removed fromstatic/app/views/discover/savedQuery/index.tsx,static/app/views/performance/transactionSummary/header.tsx, andstatic/app/views/performance/vitalDetail/vitalDetailContent.tsx.static/app/views/explore/multiQueryMode/queryConstructors/menu.tsxandstatic/app/views/explore/multiQueryMode/locationUtils.tsxwere updated, andstatic/app/views/explore/multiQueryMode/queryRow.tsxwas adjusted to remove duplicate/delete query functionality.build-acceptancescript inpackage.jsonwas modified to remove only theIS_ACCEPTANCE_TEST=1environment variable, preserving the script itself.This streamlines the codebase by removing legacy testing-specific conditional rendering and animation logic.