-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(aci): replace detectorType
with type
in detector endpoints
#93544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93544 +/- ##
===========================================
+ Coverage 46.22% 88.03% +41.80%
===========================================
Files 10275 10310 +35
Lines 592821 594376 +1555
Branches 23035 23035
===========================================
+ Hits 274048 523272 +249224
+ Misses 318339 70670 -247669
Partials 434 434 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a fixture
that is the expected data result / data body and then write a test for this? that would allow us to share the fixture with GET / POST / all the requests and ensure the responses are all the consistent.
@saponifi3d a fixture would have to be added in a different PR, since this is just part 1 (ex. we still need to update |
no worries, sounds good to add in a future pr. 👍 |
…93544) part 1 of making the POST/PUT endpoints consistent with the GET
…93544) part 1 of making the POST/PUT endpoints consistent with the GET
part 1 of making the POST/PUT endpoints consistent with the GET