Skip to content

fix(aci): replace detectorType with type in detector endpoints #93544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

ameliahsu
Copy link
Member

part 1 of making the POST/PUT endpoints consistent with the GET

@ameliahsu ameliahsu requested a review from a team as a code owner June 13, 2025 18:58
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 13, 2025
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
..._engine/endpoints/organization_detector_details.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93544       +/-   ##
===========================================
+ Coverage   46.22%   88.03%   +41.80%     
===========================================
  Files       10275    10310       +35     
  Lines      592821   594376     +1555     
  Branches    23035    23035               
===========================================
+ Hits       274048   523272   +249224     
+ Misses     318339    70670   -247669     
  Partials      434      434               

Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a fixture that is the expected data result / data body and then write a test for this? that would allow us to share the fixture with GET / POST / all the requests and ensure the responses are all the consistent.

@ameliahsu
Copy link
Member Author

@saponifi3d a fixture would have to be added in a different PR, since this is just part 1 (ex. we still need to update dataSources). there will also still be slight differences in the GET/POST since fields such as dateCreated and createdBy are not passed in the request body of a POST request, so i'm not sure if we could have a singular fixture to compare all results to.

@saponifi3d
Copy link
Contributor

a fixture would have to be added in a different PR

no worries, sounds good to add in a future pr. 👍

@ameliahsu ameliahsu merged commit be8f28e into master Jun 13, 2025
64 checks passed
@ameliahsu ameliahsu deleted the mia/aci/fix-detector-type branch June 13, 2025 20:07
billyvg pushed a commit that referenced this pull request Jun 18, 2025
…93544)

part 1 of making the POST/PUT endpoints consistent with the GET
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
…93544)

part 1 of making the POST/PUT endpoints consistent with the GET
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants