Skip to content

feat(deletions): Request Seer deletions in batches #93545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Jun 13, 2025

Some deletions are failing because the query to get group hashes times out.

Some deletions are failing because the query to get group hashes times out.
@armenzg armenzg self-assigned this Jun 13, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 13, 2025
Copy link

codecov bot commented Jun 13, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
26543 3 26540 221
View the top 3 failed test(s) by shortest run time
tests.sentry.tasks.test_delete_seer_grouping_records.TestDeleteSeerGroupingRecordsByHash::test_call_delete_seer_grouping_records_by_hash_simple
Stack Traces | 2.81s run time
#x1B[1m#x1B[.../sentry/tasks/test_delete_seer_grouping_records.py#x1B[0m:49: in test_call_delete_seer_grouping_records_by_hash_simple
    mock_logger.info.assert_called_with(
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:968: in assert_called_with
    raise AssertionError(error_message)
#x1B[1m#x1B[31mE   AssertionError: expected call not found.#x1B[0m
#x1B[1m#x1B[31mE   Expected: info('calling seer record deletion by hash', extra={'project_id': 4556241012195330, 'hashes': ['00000000000000000000000000000000', '11111111111111111111111111111111', '22222222222222222222222222222222', '33333333333333333333333333333333', '44444444444444444444444444444444']})#x1B[0m
#x1B[1m#x1B[31mE     Actual: not called.#x1B[0m
tests.sentry.tasks.test_delete_seer_grouping_records.TestDeleteSeerGroupingRecordsByHash::test_call_delete_seer_grouping_records_by_hash_no_hashes
Stack Traces | 2.82s run time
#x1B[1m#x1B[.../sentry/tasks/test_delete_seer_grouping_records.py#x1B[0m:66: in test_call_delete_seer_grouping_records_by_hash_no_hashes
    mock_logger.info.assert_called_with(
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:968: in assert_called_with
    raise AssertionError(error_message)
#x1B[1m#x1B[31mE   AssertionError: expected call not found.#x1B[0m
#x1B[1m#x1B[31mE   Expected: info('calling seer record deletion by hash', extra={'project_id': 4556241010163713, 'hashes': []})#x1B[0m
#x1B[1m#x1B[31mE     Actual: not called.#x1B[0m
tests.sentry.api.helpers.test_group_index.DeleteGroupsTest::test_delete_groups_deletes_seer_records_by_hash
Stack Traces | 2.85s run time
#x1B[1m#x1B[.../api/helpers/test_group_index.py#x1B[0m:1220: in test_delete_groups_deletes_seer_records_by_hash
    mock_logger.info.assert_called_with(
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:968: in assert_called_with
    raise AssertionError(error_message)
#x1B[1m#x1B[31mE   AssertionError: expected call not found.#x1B[0m
#x1B[1m#x1B[31mE   Expected: info('calling seer record deletion by hash', extra={'project_id': 4556240991551490, 'hashes': ['00000000000000000000000000000000', '11111111111111111111111111111111']})#x1B[0m
#x1B[1m#x1B[31mE     Actual: not called.#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant