ref(browser reporting): Use option to control Reporting-Endpoints header
#93560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93560 +/- ##
===========================================
+ Coverage 46.30% 88.00% +41.69%
===========================================
Files 10306 10322 +16
Lines 594236 594964 +728
Branches 23141 23141
===========================================
+ Hits 275175 523608 +248433
+ Misses 318568 70863 -247705
Partials 493 493 |
lobsterkatie
force-pushed
the
kmclb-use-option-for-adding-reporting-endpoints-header
branch
from
46da06e to
c8b92a1
Compare
roggenkemper
approved these changes
Jun 13, 2025
armenzg
deleted the
kmclb-use-option-for-adding-reporting-endpoints-header
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
asottile-sentry
added
the
Trigger: Revert
|
reverting: this is breaking CI |
|
PR reverted: c57c013 |
getsentry-bot
added a commit
that referenced
this pull request
Jun 16, 2025
…oints` header (#93560)" This reverts commit 74dfdaf. Co-authored-by: asottile-sentry <[email protected]>
armenzg
pushed a commit
that referenced
this pull request
Jun 16, 2025
…eader (#93560) This switches our check for whether to add the `Reporting-Endpoints` header from using `staff.is_active` (which seems to be false even if the user has `is_staff = True` in the database) to using a new option, `issues.browser_reporting.reporting_endpoints_header_enabled`.
armenzg
added a commit
that referenced
this pull request
Jun 18, 2025
) Based on @lobsterkatie 's work (#93560). Only set the `Reporting-Endpoints` header if the option `issues.browser_reporting.reporting_endpoints_header_enabled` is set (since checking for `staff.is_active` is not working as expected. Handle when the DB is not accessible by the request. --------- Co-authored-by: Katie Byers <[email protected]>
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
…eader (#93560) This switches our check for whether to add the `Reporting-Endpoints` header from using `staff.is_active` (which seems to be false even if the user has `is_staff = True` in the database) to using a new option, `issues.browser_reporting.reporting_endpoints_header_enabled`.
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
…oints` header (#93560)" This reverts commit 74dfdaf. Co-authored-by: asottile-sentry <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…eader (#93560) This switches our check for whether to add the `Reporting-Endpoints` header from using `staff.is_active` (which seems to be false even if the user has `is_staff = True` in the database) to using a new option, `issues.browser_reporting.reporting_endpoints_header_enabled`.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…oints` header (#93560)" This reverts commit 74dfdaf. Co-authored-by: asottile-sentry <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
) Based on @lobsterkatie 's work (#93560). Only set the `Reporting-Endpoints` header if the option `issues.browser_reporting.reporting_endpoints_header_enabled` is set (since checking for `staff.is_active` is not working as expected. Handle when the DB is not accessible by the request. --------- Co-authored-by: Katie Byers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches our check for whether to add the
Reporting-Endpointsheader from usingstaff.is_active(which seems to be false even if the user hasis_staff = Truein the database) to using a new option,issues.browser_reporting.reporting_endpoints_header_enabled.