feat(forms): Allow form fields to be deleted and preserve value #93564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if you want to preserve the value when adding and removing fields you would need to store the value outside the form model which defeats the purpose of the form model if you need another source of truth. Adding `preserveOnUnmount` will help us use the form model in detectors.
github-actions
bot
added
the
Scope: Frontend
malwilley
approved these changes
Jun 16, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
Right now if you want to preserve the value when adding and removing fields you would need to store the value outside the form model which defeats the purpose of the form model if you need another source of truth. Adding `preserveOnUnmount` will help us use the form model in detectors. In the below video, we'd like to be able to preserve the model's value when switching between detector types. https://github.com/user-attachments/assets/dd512ddb-9e55-449f-a5cd-0f244e747034
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Right now if you want to preserve the value when adding and removing fields you would need to store the value outside the form model which defeats the purpose of the form model if you need another source of truth. Adding `preserveOnUnmount` will help us use the form model in detectors. In the below video, we'd like to be able to preserve the model's value when switching between detector types. https://github.com/user-attachments/assets/dd512ddb-9e55-449f-a5cd-0f244e747034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you want to preserve the value when adding and removing fields you would need to store the value outside the form model which defeats the purpose of the form model if you need another source of truth.
Adding
preserveOnUnmountwill help us use the form model in detectors. In the below video, we'd like to be able to preserve the model's value when switching between detector types.CleanShot.2025-06-13.at.11.18.13.mp4