-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(feedback): frontend to display summary #93567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…d uses create_feedback
…sh/cache-ai-summary
…sh/cache-ai-summary merge the branch
…mmary-frontend merge
Jesse mentioned he'll get a design out for this with updated states for loading and if there aren't enough feedbacks. Should we merge and experiment with this for now, and make those changes in a follow-up PR? Or wait to incorporate those changes here. |
i think it's fine to merge what we're happy with here & make changes in a followup PR |
const {selection} = usePageFilters(); | ||
|
||
const normalizedDateRange = normalizeDateTimeParams(selection.datetime); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the way the date range filtering is done and from my testing (and looking at the code) this seems to work. Can you please have a look @ryan953 @michellewzhang?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woo, fewer weird things going on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, maybe the error you're seeing is similar to the one Ryan was seeing? like the LLM not generating in the right format. I'm investigating now Edit: looking at Sentry, it does seem that you were facing the same parsing error that Ryan encountered (I am encountering this too) |
…mmary-frontend merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linear ticket: https://linear.app/getsentry/issue/REPLAY-294/frontend-to-display-the-summary
Loading (placeholder) state:

Summary:

Error state:

To be honest I don't know how to implement the "Read more" logic that's on the Figma, image below:

I think I might be able to add the "Read more" on the next line, but I'm wondering that if the response is meant to be only a few sentences, do we need it?
--