Skip to content

feat(feedback): frontend to display summary #93567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 60 commits into
base: master
Choose a base branch
from

Conversation

vishnupsatish
Copy link
Member

@vishnupsatish vishnupsatish commented Jun 13, 2025

Linear ticket: https://linear.app/getsentry/issue/REPLAY-294/frontend-to-display-the-summary

Loading (placeholder) state:
image

Summary:
image

Error state:
image

To be honest I don't know how to implement the "Read more" logic that's on the Figma, image below:
image
I think I might be able to add the "Read more" on the next line, but I'm wondering that if the response is meant to be only a few sentences, do we need it?

--

  • Revert endpoint changes and feature flag default=True

@michellewzhang michellewzhang requested a review from ryan953 June 17, 2025 16:54
@vishnupsatish
Copy link
Member Author

Jesse mentioned he'll get a design out for this with updated states for loading and if there aren't enough feedbacks. Should we merge and experiment with this for now, and make those changes in a follow-up PR? Or wait to incorporate those changes here.

@michellewzhang
Copy link
Member

Jesse mentioned he'll get a design out for this with updated states for loading and if there aren't enough feedbacks. Should we merge and experiment with this for now, and make those changes in a follow-up PR? Or wait to incorporate those changes here.

i think it's fine to merge what we're happy with here & make changes in a followup PR

@vishnupsatish vishnupsatish removed the request for review from a team June 17, 2025 20:39
Comment on lines +20 to +22
const {selection} = usePageFilters();

const normalizedDateRange = normalizeDateTimeParams(selection.datetime);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the way the date range filtering is done and from my testing (and looking at the code) this seems to work. Can you please have a look @ryan953 @michellewzhang?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo, fewer weird things going on!

Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, any idea why i'm getting an error when i select any statsPeriod or some start/end times?

SCR-20250617-mtjr SCR-20250617-mptn

june 10-15 works though.

SCR-20250617-mtsb

@vishnupsatish
Copy link
Member Author

vishnupsatish commented Jun 17, 2025

hmm, maybe the error you're seeing is similar to the one Ryan was seeing? like the LLM not generating in the right format. I'm investigating now

Edit: looking at Sentry, it does seem that you were facing the same parsing error that Ryan encountered (I am encountering this too)

@vishnupsatish vishnupsatish removed the Scope: Backend Automatically applied to PRs that change backend components label Jun 18, 2025
Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super clean!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants