Skip to content

fix(replay): remove feedback from breadcrumb parser #93568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

fix(replay): remove feedback from breadcrumb parser #93568

merged 1 commit into from
Jun 16, 2025

Conversation

michellewzhang
Copy link
Member

sentry.feedback is the old UF crumb being sent from the SDK and is mostly unused/deprecated now. the new UF is now being sent in the same way that errors/issues are being sent

@michellewzhang michellewzhang requested a review from a team as a code owner June 13, 2025 22:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 13, 2025
aliu39
aliu39 reviewed Jun 16, 2025
View reviewed changes
Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to totally ignore old feedback though, or maybe rename the enum something like OLD_FEEDBACK or FEEDBACK_V1? Is this crumb emitted when sending w/the old feedback API, or is it associated to something else

@aliu39
Copy link
Member

aliu39 commented Jun 16, 2025

Just wondering in case the which code is used for things other than AI summary in the future

@aliu39 aliu39 requested a review from a team June 16, 2025 17:17
@michellewzhang
Copy link
Member Author

Do we want to totally ignore old feedback though, or maybe rename the enum something like OLD_FEEDBACK or FEEDBACK_V1? Is this crumb emitted when sending w/the old feedback API, or is it associated to something else

it's the old UF breadcrumb that we don't care about anymore -- we removed it from showing up in replay breadcrumbs completely: #67527. so i don't think we need to keep it as a case

@aliu39
Copy link
Member

aliu39 commented Jun 16, 2025

Ah got it thanks!

Do we want to totally ignore old feedback though, or maybe rename the enum something like OLD_FEEDBACK or FEEDBACK_V1? Is this crumb emitted when sending w/the old feedback API, or is it associated to something else

it's the old UF breadcrumb that we don't care about anymore -- we removed it from showing up in replay breadcrumbs completely: #67527. so i don't think we need to keep it as a case

@michellewzhang michellewzhang merged commit f91b091 into master Jun 16, 2025
65 checks passed
@michellewzhang michellewzhang deleted the mz/rm-feedback-event-parser branch June 16, 2025 18:46
billyvg pushed a commit that referenced this pull request Jun 18, 2025
@michellewzhang @billyvg
fix(replay): remove feedback from breadcrumb parser (#93568)
61e8faf 
`sentry.feedback` is the old UF crumb being sent from the SDK and is
mostly unused/deprecated now. the new UF is now being sent in the same
way that errors/issues are being sent
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@michellewzhang @andrewshie-sentry
fix(replay): remove feedback from breadcrumb parser (#93568)
e16159a 
`sentry.feedback` is the old UF crumb being sent from the SDK and is
mostly unused/deprecated now. the new UF is now being sent in the same
way that errors/issues are being sent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliu39 aliu39 aliu39 left review comments

@cmanallen cmanallen cmanallen approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michellewzhang @aliu39 @cmanallen