feat(billing): allow _admin to start product trial for enterprise orgs #93570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93570 +/- ##
==========================================
- Coverage 83.12% 83.10% -0.02%
==========================================
Files 10324 10326 +2
Lines 595574 595663 +89
Branches 23135 23137 +2
==========================================
+ Hits 495045 495050 +5
- Misses 100035 100120 +85
+ Partials 494 493 -1 |
vbro
force-pushed
the
vbro_admin_product_trial_ent
branch
from
6fc6e40 to
96693c8
Compare
isabellaenriquez
approved these changes
Jun 17, 2025
Comment on lines
388
to
389
| expect(screen.getByText('Spans:')).toBeInTheDocument(); | ||
| expect(screen.getByText('Seer:')).toBeInTheDocument(); |
There was a problem hiding this comment.
is there a reason we just test for these two?
There was a problem hiding this comment.
Ooops, I forgot to add those back after playing around with the test file.
Good catch!
| @@ -367,7 +367,7 @@ describe('CustomerOverview', function () { | |||
| expect(screen.queryByText('Seer:')).not.toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| it('renders no product trials for non-self-serve account', function () { | |||
| it('renders product trials for non-self-serve account', function () { | |||
| const organization = OrganizationFixture(); | |||
| const enterprise_subscription = SubscriptionFixture({ | |||
There was a problem hiding this comment.
i realized we can just use InvoicedSubscriptionFixture instead of having to overwrite canSelfServe here
Co-authored-by: Isabella Enriquez <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
#93570) Co-authored-by: Isabella Enriquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.