Skip to content

feat(devservices): Add crons devservices mode #93573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025

Conversation

hubertdeng123
Copy link
Member

This should be the minimal subset of dependencies needed for development with crons. Tested locally to ensure a monitor is ingested correctly

@hubertdeng123 hubertdeng123 marked this pull request as ready for review June 17, 2025 18:07
@hubertdeng123 hubertdeng123 requested review from a team as code owners June 17, 2025 18:07
@hubertdeng123 hubertdeng123 requested a review from a team June 17, 2025 18:07
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need redis too

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Jun 17, 2025

We might need redis too

Redis will be brought up automatically since snuba and relay need it

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93573      +/-   ##
==========================================
+ Coverage   88.03%   88.04%   +0.01%     
==========================================
  Files       10329    10330       +1     
  Lines      596109   595877     -232     
  Branches    23146    23109      -37     
==========================================
- Hits       524756   524617     -139     
+ Misses      70897    70767     -130     
- Partials      456      493      +37     

@hubertdeng123 hubertdeng123 merged commit 32380a9 into master Jun 17, 2025
61 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng/add-crons-devservices-mode branch June 17, 2025 22:23
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
This should be the minimal subset of dependencies needed for development
with crons. Tested locally to ensure a monitor is ingested correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants