-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(devservices): Add crons devservices mode #93573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need redis too
Redis will be brought up automatically since snuba and relay need it |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93573 +/- ##
==========================================
+ Coverage 88.03% 88.04% +0.01%
==========================================
Files 10329 10330 +1
Lines 596109 595877 -232
Branches 23146 23109 -37
==========================================
- Hits 524756 524617 -139
+ Misses 70897 70767 -130
- Partials 456 493 +37 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
This should be the minimal subset of dependencies needed for development with crons. Tested locally to ensure a monitor is ingested correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the minimal subset of dependencies needed for development with crons. Tested locally to ensure a monitor is ingested correctly