feat(dashboards): Add feature flag for positional starred dashboards #93597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will gate some functionality such as updating positions during favoriting actions. To separate the existing flow from the new code that supports reodering
github-actions
bot
added
the
Scope: Backend
nikkikapadia
approved these changes
Jun 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93597 +/- ##
==========================================
- Coverage 88.01% 88.01% -0.01%
==========================================
Files 10322 10322
Lines 595057 595054 -3
Branches 23125 23124 -1
==========================================
- Hits 523725 523721 -4
- Misses 70839 70840 +1
Partials 493 493 |
…oards-feature-flag
narsaynorath
deleted the
nar/feat/dashboards-starred-position-dashboards-feature-flag
branch
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
…93597) I will gate some functionality such as updating positions during favoriting actions to separate the existing flow from the new code that supports reodering Also removes the old feature flag for the favorites feature because I've also removed the flag checks elsewhere.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…93597) I will gate some functionality such as updating positions during favoriting actions to separate the existing flow from the new code that supports reodering Also removes the old feature flag for the favorites feature because I've also removed the flag checks elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will gate some functionality such as updating positions during favoriting actions to separate the existing flow from the new code that supports reodering
Also removes the old feature flag for the favorites feature because I've also removed the flag checks elsewhere.