fix(dashboards): Alert on committing changes #93605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue where if a user submits changes and the saving is taking a long time, when the user attempts to refresh they'll query old data. Now we at least indicate to the user that there are possibly unsaved changes so they can wait. This is only applied to the before unload listener because I think it's unnecessary to warn on this for navigations, since likely if you navigate away you're leaving the view long enough for it to commit properly before returning.
narsaynorath
changed the title
github-actions
bot
added
the
Scope: Frontend
gggritso
approved these changes
Jun 17, 2025
narsaynorath
deleted the
narsaynorath/dain-621-add-warning-during-ongoing-saves-to-alert-users-for
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
This fixes the issue where if a user submits changes and the saving is taking a long time, when the user attempts to refresh they'll query old data. Now we at least indicate to the user that there are possibly unsaved changes so they can wait. This will alert on dashboard saves (edit mode saving) to any updates by adding or editing widgets This is only applied to the before unload listener because I think it's unnecessary to warn on this for navigations, since likely if you navigate away you're leaving the view long enough for it to commit properly before returning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where if a user submits changes and the saving is taking a long time, when the user attempts to refresh they'll query old data. Now we at least indicate to the user that there are possibly unsaved changes so they can wait. This will alert on dashboard saves (edit mode saving) to any updates by adding or editing widgets
This is only applied to the before unload listener because I think it's unnecessary to warn on this for navigations, since likely if you navigate away you're leaving the view long enough for it to commit properly before returning.