Skip to content

fix(self-hosted): Use json to define dockerfile entrypoint #93623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

fix(self-hosted): Use json to define dockerfile entrypoint #93623

merged 1 commit into from
Jun 16, 2025

Conversation

scttcper
Copy link
Member

Original: Runs through shell, passes $0 (command name) and $@ (all arguments) to the script
New: Directly executes the script and automatically appends CMD arguments

image

@scttcper
fix(self-hosted): Use json to define dockerfile entrypoint
4f085f3 
Original: Runs through shell, passes $0 (command name) and $@ (all arguments) to the script
New: Directly executes the script and automatically appends CMD arguments
@scttcper scttcper requested a review from a team June 16, 2025 17:01
@scttcper scttcper requested a review from a team as a code owner June 16, 2025 17:01
hubertdeng123
hubertdeng123 reviewed Jun 16, 2025
View reviewed changes
Copy link
Member

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can test this out when this is in, and revert if needed

@scttcper scttcper merged commit d2e7eca into master Jun 16, 2025
35 checks passed
@scttcper scttcper deleted the scttcper/dockerfile-entrypoint branch June 16, 2025 17:39
billyvg pushed a commit that referenced this pull request Jun 18, 2025
@scttcper @billyvg
fix(self-hosted): Use json to define dockerfile entrypoint (#93623)
ef25cb0 
Original: Runs through shell, passes $0 (command name) and $@ (all
arguments) to the script
New: Directly executes the script and automatically appends CMD
arguments


![image](https://github.com/user-attachments/assets/58cfe31a-9302-48fa-acb8-5bd658d6257d)
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@scttcper @andrewshie-sentry
fix(self-hosted): Use json to define dockerfile entrypoint (#93623)
359a05d 
Original: Runs through shell, passes $0 (command name) and $@ (all
arguments) to the script
New: Directly executes the script and automatically appends CMD
arguments


![image](https://github.com/user-attachments/assets/58cfe31a-9302-48fa-acb8-5bd658d6257d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertdeng123 hubertdeng123 hubertdeng123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scttcper @hubertdeng123