feat(dashboards): Update the endpoint to use manager to favorite #93625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the endpoint so it uses the DashboardFavoriteUser manager to create updates. This has the benefit that the API will update positions as well. These tests and uses currently expect that all positions are set properly, or else the operations will error trying to increment or decrement positions.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93625 +/- ##
==========================================
- Coverage 88.01% 83.29% -4.73%
==========================================
Files 10324 10326 +2
Lines 595076 595645 +569
Branches 23125 23125
==========================================
- Hits 523749 496127 -27622
- Misses 70834 99025 +28191
Partials 493 493 |
narsaynorath
commented
Jun 16, 2025
Comment on lines
+220
to
+221
| if not request.user.is_authenticated: | ||
| return Response(status=401) |
There was a problem hiding this comment.
Had to add this because the calls to the helpers from the DashboardFavoriteUser object managers were complaining. user_id is typed as an int and without this call, the typing of the request.user object is possibly AnonymousUser which I suppose doesn't have an ID
Checking for auth fixes the type issue
narsaynorath
deleted the
narsaynorath/dain-540-update-the-endpoint-to-append-to-the-last-position
branch
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
) This updates the endpoint so it uses the DashboardFavoriteUser manager to create updates. This has the benefit that the API will update positions as well. These tests and uses currently expect that all positions are set properly, or else the operations will error trying to increment or decrement positions. Enforcing positions to be filled in will be a separate PR, for now this is feature flagged so it can make this assumption.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
) This updates the endpoint so it uses the DashboardFavoriteUser manager to create updates. This has the benefit that the API will update positions as well. These tests and uses currently expect that all positions are set properly, or else the operations will error trying to increment or decrement positions. Enforcing positions to be filled in will be a separate PR, for now this is feature flagged so it can make this assumption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the endpoint so it uses the DashboardFavoriteUser manager to create updates. This has the benefit that the API will update positions as well.
These tests and uses currently expect that all positions are set properly, or else the operations will error trying to increment or decrement positions. Enforcing positions to be filled in will be a separate PR, for now this is feature flagged so it can make this assumption.